Pass any variables between stages #45

roquie · 2018-06-13T18:33:51Z

Work example:

require __DIR__ . '/vendor/autoload.php';

use League\Pipeline\Pipeline;

$pipeline = (new Pipeline)
    ->pipe(function ($payload, $dto) {
        $dto['ten'] = 10;
        return $payload * 2;
    })
    ->pipe(function ($payload, $dto) {
        return $payload + $dto['ten'];
    });

echo $pipeline->process(5, new ArrayObject());
// 20

Also I added docblocks for better IDE autocomplete. Full backward compatibility.

shadowhand · 2018-06-16T22:35:23Z

src/Pipeline.php

+     *
+     * @param callable $stage
+     * @return \League\Pipeline\PipelineInterface|$this
+     */


Not needed, PipelineInterface already provides all the docblocks. Same for other docblocks added in this PR.

For others -- ok. But for this docblock for PipelineInterface returns only interface without $this. IDE autocompletion works only within interface scope and not touch process method which should be there.

shadowhand · 2018-06-16T22:36:53Z

src/FingersCrossedProcessor.php

 {
+    use ParametersTrait;
+
    public function process($payload, callable ...$stages)


Hmm I forgot about this signature, makes it significantly trickier to handle. It's pretty straight forward for the Pipeline:

function process(...$parameters) { ... }

But the processor is different because it receives the stages:

function process($payload, callable ...$stages) { ... }

shadowhand · 2018-06-16T22:40:00Z

src/Pipeline.php

+            $this->processor->setParameters(...$params);
+            return $this->processor->process($payload, ...$this->stages);
+        }
+
        return $this->processor->process($payload, ...$this->stages);


It might make more sense for this to be:

return $this->processor->withParameters($params)->process(...$this->stages);

Doing so will change the signatures significantly though, and cause a major version bump.

Let me think about this for a couple of days.

Yes, your variant is more elegant, but needs to bump the major version.

Let me think about this for a couple of days.

ok.

Pass any variables between stages.

7944207

roquie mentioned this pull request Jun 13, 2018

Add variadic variable to __invoke #18

Open

shadowhand reviewed Jun 16, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pass any variables between stages #45

Pass any variables between stages #45

roquie commented Jun 13, 2018 •

edited

Loading

shadowhand Jun 16, 2018

roquie Jun 17, 2018 •

edited

Loading

shadowhand Jun 16, 2018

shadowhand Jun 16, 2018

roquie Jun 17, 2018

Pass any variables between stages #45

Are you sure you want to change the base?

Pass any variables between stages #45

Conversation

roquie commented Jun 13, 2018 • edited Loading

shadowhand Jun 16, 2018

Choose a reason for hiding this comment

roquie Jun 17, 2018 • edited Loading

Choose a reason for hiding this comment

shadowhand Jun 16, 2018

Choose a reason for hiding this comment

shadowhand Jun 16, 2018

Choose a reason for hiding this comment

roquie Jun 17, 2018

Choose a reason for hiding this comment

roquie commented Jun 13, 2018 •

edited

Loading

roquie Jun 17, 2018 •

edited

Loading